Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClasspathURLProvider implementation that reads system properties #29995

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

linghengqian
Copy link
Member

For #29052.

Changes proposed in this pull request:

  • Add ClasspathURLProvider implementation that reads system properties. For nativeTest, we need a way to dynamically define properties in a YAML file. To cover the JDBC Driver scenario, I don't think the lower level Java API should be used in nativeTest.
  • This PR simultaneously modifies some nativeTest, especially to further prevent the problem discovered by Add GraalVM Reachability Metadata and corresponding nativeTest for Etcd integration #29755 that the ports involved in MySQL's nativeTest are occupied by unknown applications.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review February 4, 2024 17:45
@RaigorJiang RaigorJiang added this to the 5.5.0 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants