Update for Sidekiq 7 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace fakeredis by a real redis because it is not compatible with Sidekiq 7 and the new redis-client gem [1]. - Fix tests. [1]: guilleiguaran/fakeredis#270
- Remove unsupported Ruby versions. - Add redis service to github actions.
Closed
|
Thank you @martijnbolhuis & @gammons, merging it to master - please let me know if it works I'll then bump the version and release. |
|
@nglx can you do a gem release with this PR in it? Thank you! |
G-Rath
added a commit
to ackama/nzsl-share
that referenced
this pull request
Jul 21, 2024
Support for Sidekiq v7 has been landed in the repository (breamware/sidekiq-batch#89 & breamware/sidekiq-batch#85), but not yet released - hopefully that'll happen soon, but in the meantime I'm switching us to pull from the repository because 1. it sounds like that includes some further fixes which might be useful to us 2. the ubuntu-24 stack on Heroku no longer has `git` at runtime which looks to be causing our deployment to fail because `sidekiq-batch.gemspec` tries to do `git ls-remote -z` for determining the files to include; we might still run into issues because we're technically still using `git`, but I'm hoping this moves our usage into the "build" phase where `git` should still be available...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the changes from #88 and fixed the tests. Please have a look if these changes make sense.
booleans 1.
fakeredis is not compatible with Sidekiq 7 and the redis-client gem 2.