Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the test infrastructure to Testcontainers #925

Closed
jmini opened this issue Mar 17, 2023 · 1 comment
Closed

Move the test infrastructure to Testcontainers #925

jmini opened this issue Mar 17, 2023 · 1 comment
Assignees

Comments

@jmini
Copy link
Collaborator

jmini commented Mar 17, 2023

Currently some integration are running against a GitLab started in docker, controlled by those properties in the POM:

gitlab4j-api/pom.xml

Lines 69 to 72 in b2942f3

<gitlab.version>12.9.2-ce.0</gitlab.version>
<gitlab.autoremove-container>true</gitlab.autoremove-container>
<gitlab.skip-docker-start>true</gitlab.skip-docker-start>
<gitlab.port>8090</gitlab.port>

  • The GitLab version version is old.
  • Tests rely on maven starting the container using the io.fabric8:docker-maven-plugin plugin.
  • It is not easy to skip the integration tests on a computer where docker is not installed.

The Testcontainers is a popular project where integration tests declare their dependencies directly in the code (next to the tests).


It would be also handy to be able to test against multiple GitLab versions, for example the one listed in the version selector on https://docs.gitlab.com/.

GitLab version selector in the docs

For example as of today this would be:

  • 15.9
  • 14.10
  • 13.10

This is open for suggestions

@jmini
Copy link
Collaborator Author

jmini commented Sep 20, 2024

I am working on an other approach for our integration tests. See: #1165

@jmini jmini closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants