fix: Use constructor injection instead of field injection in Java code in Challenge-Service App #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove openchallenges-minio * Remove references to MinIO * Remove references to MinIO
* remove drop shadow from org card * remove drop shadow from goal card * add grey border around logo on org card
…networks#1904) * add default value for missing DOI * update name of template * add default value for empty inputDataTypes * add default value for empty incentives * use grey text for "NA" values
* Remove OC DB CLI * Remove references to OC DB CLI * Remove references to OC DB CLI
…networks#1893) * add angular to get contributions * change orgId t o string * replace sponsors with contributors * update org card component * update some org card layouts * not show members by default and update org card layouts * use `grid` on card-group to better fit our cards layout * hide members * fix cards layout in home * add brief description to profile page sections (#2) * Update libs/openchallenges/challenge/src/lib/challenge-contributors/challenge-contributors.component.html Co-authored-by: Thomas Schaffter <[email protected]> * fix grid space for person cards * fix org-member's space --------- Co-authored-by: Verena Chung <[email protected]> Co-authored-by: Thomas Schaffter <[email protected]>
* Add `Data updated on` to the footer * Update config for container
…`challenge_count` (Sage-Bionetworks#1910) * change default sort to challenge_count in org search * sort orgs in challenge contributors * sort by alphabetic in challenge-contributors
* reorder filters for challenges * open all filters for challenges * comment out input data type filter * move year down * add back input data type and put dropdowns together * move input data type up * hide input data type filter
* diable user direction * hide challenge-stargazers * hide user metrics in home * hide star button on cards
* Limit to 3 members per row * Add link to profiles * Add LinkedIn icon for maria but wo url for now * Make .card-roles use all its space * Fix width of the roles instead of using br * Pack together the members and add bmargin below team * Update libs/openchallenges/team/src/lib/team.component.html Co-authored-by: Verena Chung <[email protected]> * RRemove maria Linkedin --------- Co-authored-by: Verena Chung <[email protected]>
…etworks#1921) * make width of challenge and org cards consistent * fix failed test on org-card * remove row col in parent tag of car-group
* Add prod cert * Fix typo * Keep a single cert * Undo changes * More undo * Fix stack after forgetting initial cert
* Add Tag Manager code to header * Add Google Tag Manager * Remove GTM from index.html * Send GTM tag when loading a page * Send tag when viewing a page
…-Bionetworks#1941) * Use new cert with the preview instance ALB * Add new DNS record
* add blank text * add some colors * adjust spacing a bit * Update libs/openchallenges/home/src/lib/home.component.html Co-authored-by: Verena Chung <[email protected]> * Update libs/openchallenges/home/src/lib/home.component.html Co-authored-by: Thomas Schaffter <[email protected]> * update some texts * adjust color using amber50&500 * fix typo * Update libs/openchallenges/home/src/lib/home.component.html Co-authored-by: Verena Chung <[email protected]> * remove redirection link to about page --------- Co-authored-by: Verena Chung <[email protected]> Co-authored-by: Thomas Schaffter <[email protected]>
* replace auto-fit by auto-fill * remove justify-items in home since not needed anymore * add media for card-group * update spacing for person card * change to use fixed width for cards * use 320px back for card width * align center for cards in home * change back to 300px since limited space in search page
* hide stargazers metric * show N number of views * hide verfication badge for now
* daily update; add 1 new challenge * daly update; add 3 new orgs * update challenge headlines and descriptions * add new platform * add new challenges * update org desc * add new orgs * add platform for "other" * update associating platform IDs * add 3 challenges * add 8 orgs; update challenge counts * fix: add "" to enum of status values * revert 594b45b "fix" ('twas not a fix...) * give "Other" platform id of 0 * reassign og platform ids; assign statuses to empty ones * assign id=14 for "Other" platform * add 2 challenges * add 6 orgs * Add Eterna logo * Update app data last updated on * Update app data last updated on --------- Co-authored-by: Thomas Schaffter <[email protected]>
…etworks#1903) * add endpoint * filled in docstrings * fix backward arguments * moved schemaUrl from path to query folder * fix c+p error * handle merge conflict * fix typo
…alone components (Sage-Bionetworks#1957) * Convert challenge-contributor to standalone * Convert challenge-organizers to standalone * Convert all components to standalone * Finalize challenge project
* Update the image service to use gradle v8 * Update the image service to use gradle v8 * Update the challenge service * Update the organization service * Update the apu gateway * Update the auth-service * Update challenge-to-elasticsearch-service * Update config-server * Update core-service * Update kaggle-to-kafka-service * Update service-registry * Update user-service * Update app-config-data * Update kafka-admin * Update kafka-consumer * Update kafka-model * Update kafka-producer * Update shared-java-util
* Add sonar scanner tool * Validate args * Define sonar task for openchallenges-app
* Simplify the syntax of the `sonar` task * Update the sonar task of openchallenges-app * Fix doc
* Create CODE_QUALITY.md * Add more projects * Use bold font for product name * Add data for OC organization service * Add metrics for OC challenge service * Add Section Definitions
…rks#2076) * Remove `shx` * Rename task `prepare` to `create-config`
…rks#2079) * Update OpenAPI Generator to v7 * Regenerate image service * Run OpenAPI Generator and fixes issues * Update tool
* Define prepare task for R projects * Small improvement * Define prepare task for Java projects * Define prepare task for Python projects * Update command `workspace-install`
* Add the command `workspace-install-affected` * Use new command in CI workflow
* Restore changes made in Sage-Bionetworks#2023 * Remove 2 deprecated workflow * Add VS Code extension `github.vscode-github-actions` * Add VS Code extension `ms-playwright.playwright`
mdsage1
changed the title
mdsage1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Sage-Bionetworks#1392 - Partially by addressing all instances where constructor injection instead of field injection in Java code in the challenge-service app of openchallenges.
Changelog
Updated the following:
ChallengeService.java - now using constructor injection instead of field injection in Java code
ChallengePlatformService.java - now using constructor injection instead of field injection in Java code
ChallengeInputDataTypeService.java - now using constructor injection instead of field injection in Java code
SecurityConfiguration.java - now using constructor injection instead of field injection in Java code
KeycloakManager.java - now using constructor injection instead of field injection in Java code
HibernateSearchIndexBuild.java - now using constructor injection instead of field injection in Java code