Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use constructor injection instead of field injection in Java code in Challenge-Service App #1

Merged
merged 89 commits into from
Sep 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
7f6407b
chore: Remove OpenChallenges MinIO (#1880)
tschaffter Aug 2, 2023
e218629
fix(ui): remove drop shadows from select cards (#1905)
vpchung Aug 2, 2023
119d8df
fix(ui): Add default text for empty fields on profile pages (#1904)
vpchung Aug 2, 2023
62cfb5e
chore: Remove OpenChallenges DB CLI (#1882)
tschaffter Aug 2, 2023
ca40032
Remove About button from the navbar (#1911)
tschaffter Aug 3, 2023
35d5a8f
feat: Implement challenge contributors in Challenge Profile (#1893)
rrchai Aug 3, 2023
f33869b
feat: Specify the data version in the OC footer (#1916)
tschaffter Aug 3, 2023
5fc2882
feat(ui): Modify the default organization sorting to be based on the …
rrchai Aug 3, 2023
ebba939
feat(ui): Open and reorder challenge filters (#1908)
rrchai Aug 3, 2023
7e14b40
feat(ui): Hide user related widgets across app (#1915)
rrchai Aug 3, 2023
7f84dbc
docs: Update the Team page (#1919)
tschaffter Aug 3, 2023
e45d61e
feat(ui): Make width of challenge and org cards consistent (#1921)
rrchai Aug 3, 2023
a4f2cfe
fix: Use default avatar if image service is down (#1924)
rrchai Aug 4, 2023
a0a3c57
Fix tag (#1927)
tschaffter Aug 4, 2023
844113f
add default text when array is empty (#1922)
rrchai Aug 4, 2023
5727797
feat: Add ACM certificate for OC prod DNS (#1925)
tschaffter Aug 4, 2023
76cc571
Remove Amy from the Team page (#1930)
tschaffter Aug 4, 2023
bee14e7
move description out of conditional container (#1934)
rrchai Aug 4, 2023
a4a52f5
Add code owners to schematic (#1938)
tschaffter Aug 4, 2023
2f52342
feat: Setup Google Analytics (#1923)
tschaffter Aug 4, 2023
0a0b5e8
chore: Point `openchallenges.io` to the OC preview EC2 instance (#1941)
tschaffter Aug 4, 2023
bda97bc
feat(ui): Add announcement box in the home page (#1939)
rrchai Aug 5, 2023
8f5f605
feat(data): Add new challenges and organizations (#1942)
vpchung Aug 5, 2023
3e166c6
feat(ui): Adjust layout of cards (#1932)
rrchai Aug 5, 2023
f387341
add default value for difficulty (#1943)
vpchung Aug 5, 2023
5944f5a
fix(ui): Hide in-progess items for soft launch (#1944)
vpchung Aug 5, 2023
681f486
add new endpoint (#1902)
andrewelamb Aug 14, 2023
29a3670
feat(data): weekly OC db update (#1952)
vpchung Aug 14, 2023
91cdfae
feat: Add /components/{componentLabel}/attributes endpoint (#1903)
andrewelamb Aug 14, 2023
d585f1e
chore(ng): Migrate the project `openchallenges-challenge` to Ng stand…
tschaffter Aug 14, 2023
10fefc2
chore(ng): Migrate the project `openchallenges-home` and `openchalle…
tschaffter Aug 14, 2023
5f8a98a
chore(ng): Migrate projects to ng standalone components (Part 3) (#1961)
tschaffter Aug 14, 2023
63c6fc0
chore(ng): Migrate the project `openchallenges-ui` to Ng standalone c…
tschaffter Aug 15, 2023
27e73f0
Remove modules from openchallenges-auth (#1968)
tschaffter Aug 15, 2023
df9fdd5
Remove auth and login projects (#1971)
tschaffter Aug 15, 2023
b6b7fe7
chore(ng): Migrate to Ng self-closing tags (#1973)
tschaffter Aug 16, 2023
46ba9e1
feat: Investigate yarn cache folder (#1979)
tschaffter Aug 17, 2023
dbda409
feat: Cache R packages in CI workflow (#1982)
tschaffter Aug 18, 2023
7dbd1ae
Patch publish-image in CI workflow (#1984)
tschaffter Aug 18, 2023
9807dd9
feat: Add /nodes/{nodeLabel}/dependencies endpoint (#1913)
andrewelamb Aug 18, 2023
326f4b8
feat: Cache Poetry and venv in CI workflow (#1983)
tschaffter Aug 18, 2023
04e4850
feat: Cache Gradle in CI workflow (#1988)
tschaffter Aug 18, 2023
1b53778
Remove mongoose Node.js package (#1990)
tschaffter Aug 19, 2023
886fd32
Remove tput dependency from dev-env.sh (#1991)
tschaffter Aug 19, 2023
f864cc4
fix: Update dev-env.sh
tschaffter Aug 19, 2023
6890bb4
chore: Migrate the project openchallenges-app to Ng standalone compon…
tschaffter Aug 19, 2023
b03cab5
Upgrade nx (#1997)
tschaffter Aug 21, 2023
05a5bd3
Add pnpm to the devcontainer (#1999)
tschaffter Aug 21, 2023
15ec53e
chore(tools): Add SonarScanner CLI to the devcontainer (#2000)
tschaffter Aug 21, 2023
7923090
Use new devcontainer that provides SonarScanner CLI (#2002)
tschaffter Aug 22, 2023
0054955
feat(ui): Adjust long texts to better fit on challenge card (#1987)
rrchai Aug 23, 2023
f3ff5cb
feat: add /nodes/{nodeLabel}/validationRules endpoint (#1918)
andrewelamb Aug 24, 2023
fd1e274
fix: Fix CI workflow access to Yarn cache folder (#2012)
tschaffter Aug 25, 2023
6a3ec60
Disable docker push in CI workflow on main (#2014)
tschaffter Aug 25, 2023
866144f
Update root .gitignore ahead of pnpm (#2009)
tschaffter Aug 25, 2023
6352f91
feat: Change endpoint names to use nodes instead of components (#1977)
andrewelamb Aug 25, 2023
0d98658
chore: Update Dev Container CLI (#2024)
tschaffter Aug 27, 2023
46d81e7
feat: Notify Developers when they need to update VS Code (#2010)
tschaffter Aug 28, 2023
96eebe2
Update `lint-pr` workflow (#2034)
tschaffter Aug 28, 2023
dc970ca
feat: Navigate to search pages when clicking on the home page stats (…
tschaffter Aug 29, 2023
9f9ef48
Annotate projects with `language` and `project-manager` tags (#2037)
tschaffter Aug 29, 2023
1d21c1c
feat: Generate and publish coverage report for one Java project (#2032)
tschaffter Aug 29, 2023
63feacd
fix endpoint name (#2041)
andrewelamb Aug 29, 2023
91ae540
feat: Add /assetTypes/{assetType}/assetViews/{assetViewId}/datasets/{…
andrewelamb Aug 29, 2023
5f79461
Remove Cython patch from `schematic-api` (#2044)
tschaffter Aug 29, 2023
b7a153e
ci: Push Sonar scan results when pushing to `main` (#2043)
tschaffter Aug 29, 2023
751a9d4
Define SONAR_TOKEN in CI workflow (#2046)
tschaffter Aug 29, 2023
cbea3d5
chore(java): Upgrade to Gradle v8 (#2050)
tschaffter Aug 30, 2023
467b31f
feat: Scan OC Angular app with Sonar (#2052)
tschaffter Aug 30, 2023
016fe5b
ci: Scan Schematic API with Sonar (#2054)
tschaffter Aug 30, 2023
1e60b16
Update list of products in GH issue templates (#2058)
tschaffter Aug 30, 2023
afa5325
ci: Configure sonar for OC organization service (#2059)
tschaffter Sep 1, 2023
e7cd12e
Configure Sonar for the OC challenge service (#2070)
tschaffter Sep 1, 2023
a79a204
docs: Create dashboard to track code quality (#2056)
tschaffter Sep 2, 2023
be6a67a
refactor: Rename the task `prepare` to `create-config` (#2076)
tschaffter Sep 4, 2023
4b3b0ea
Update IBM OpenAPI Validator (#2077)
tschaffter Sep 4, 2023
a8d3095
chore: Update OC image service to OpenAPI Generator v7 (#2079)
tschaffter Sep 5, 2023
f6fb6d3
refactor: Deprecate tasks `prepare-<languages>` (#2083)
tschaffter Sep 5, 2023
ad5e12f
Check if there are containers to stop (#2086)
tschaffter Sep 6, 2023
7ef0439
ci: Add the command `workspace-install-affected` (#2089)
tschaffter Sep 6, 2023
33d2028
chore: Update the Dev Container August 2023 (#2025)
tschaffter Sep 6, 2023
f9636e8
update index.build
mdsage1 Sep 7, 2023
aaf9eac
modified keycloak KeycloakManager
mdsage1 Sep 7, 2023
d412a95
modified keycloak KeycloakManager
mdsage1 Sep 7, 2023
160210c
update SecurityCOnfiguration
mdsage1 Sep 7, 2023
f7c054f
last files updated
mdsage1 Sep 7, 2023
6c33ded
update final files
mdsage1 Sep 7, 2023
f482f91
update final field to constructor injectioins
mdsage1 Sep 8, 2023
20f68d4
update typo
mdsage1 Sep 8, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
27 changes: 12 additions & 15 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Sage Dev Container",
"image": "ghcr.io/sage-bionetworks/sage-devcontainer:55645b0",
"image": "ghcr.io/sage-bionetworks/sage-devcontainer:0d98658",

"containerEnv": {
"NX_BASE": "${localEnv:NX_BASE}",
Expand All @@ -9,12 +9,14 @@
"NX_CLOUD_ENCRYPTION_KEY": "${localEnv:NX_CLOUD_ENCRYPTION_KEY}",
"NX_CLOUD_ENV_NAME": "${localEnv:NX_CLOUD_ENV_NAME}",
"NX_HEAD": "${localEnv:NX_HEAD}",
"NX_RUN_GROUP": "${localEnv:NX_RUN_GROUP}"
"NX_RUN_GROUP": "${localEnv:NX_RUN_GROUP}",
"SONAR_TOKEN": "${localEnv:SONAR_TOKEN}"
},

"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2.2.0": {
"version": "20.10.24"
"ghcr.io/devcontainers/features/docker-in-docker:2.4.0": {
"version": "24.0.5",
"moby": false
}
},

Expand All @@ -26,22 +28,27 @@
},
"vscode": {
"extensions": [
"1000ch.svgo",
"alefragnani.Bookmarks",
"Angular.ng-template",
"dbaeumer.vscode-eslint",
"eamodio.gitlens",
"emeraldwalk.RunOnSave",
"esbenp.prettier-vscode",
"firsttris.vscode-jest-runner",
"formulahendry.auto-rename-tag",
"github.vscode-github-actions",
"GitHub.vscode-pull-request-github",
"Gruntfuggly.todo-tree",
"humao.rest-client",
"mhutchie.git-graph",
"mongodb.mongodb-vscode",
"ms-playwright.playwright",
"ms-python.python",
"mtxr.sqltools-driver-mysql",
"mtxr.sqltools-driver-pg",
"mtxr.sqltools",
"nrwl.angular-console",
"pranaygp.vscode-css-peek",
"ritwickdey.LiveServer",
"shengchen.vscode-checkstyle",
"SonarSource.sonarlint-vscode",
Expand Down Expand Up @@ -84,8 +91,6 @@
8787,
8888,
8889,
9000,
9001,
9090,
9104,
9200,
Expand Down Expand Up @@ -206,14 +211,6 @@
"label": "openchallenges-thumbor",
"onAutoForward": "silent"
},
"9000": {
"label": "openchallenges-minio",
"onAutoForward": "silent"
},
"9001": {
"label": "openchallenges-minio (console)",
"onAutoForward": "silent"
},
"9090": {
"label": "openchallenges-prometheus",
"onAutoForward": "silent"
Expand Down
8 changes: 4 additions & 4 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
* @tschaffter

/apps/openchallenges/ @tschaffter @rrchai @vpchung
/libs/openchallenges/ @tschaffter @rrchai @vpchung
/apps/openchallenges/ @rrchai @tschaffter @vpchung
/libs/openchallenges/ @rrchai @tschaffter @vpchung

/apps/schematic/ @linglp @andrewelamb
/libs/schematic/ @linglp @andrewelamb
/apps/schematic/ @andrewelamb @GiaJordan @linglp @mialy-defelice @milen-sage
/libs/schematic/ @andrewelamb @GiaJordan @linglp @mialy-defelice @milen-sage

/libs/shared/ @tschaffter
8 changes: 6 additions & 2 deletions .github/ISSUE_TEMPLATE/1-bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,17 @@ body:
- label: I have searched the existing issues
required: true
- type: dropdown
id: projects
id: products
attributes:
label: What projects are you seeing the problem on?
label: What product(s) are you seeing the problem on?
multiple: true
options:
- Agora
- OpenChallenges
- Sage Monorepo
- Schematic
- Synapse
- Other
- type: textarea
attributes:
label: Current behavior
Expand Down
8 changes: 6 additions & 2 deletions .github/ISSUE_TEMPLATE/2-feature.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,17 @@ title: '[Feature] <title>'
labels: ['type: feature']
body:
- type: dropdown
id: projects
id: products
attributes:
label: What projects is this feature for?
label: What product(s) is this feature for?
multiple: true
options:
- Agora
- OpenChallenges
- Sage Monorepo
- Schematic
- Synapse
- Other
- type: textarea
attributes:
label: Description
Expand Down
7 changes: 5 additions & 2 deletions .github/ISSUE_TEMPLATE/3-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@ title: '[Docs] <title>'
labels: ['type: docs']
body:
- type: dropdown
id: projects
id: products
attributes:
label: What projects is this documentation issue for?
label: What product(s) is this documentation issue for?
multiple: true
options:
- Agora
- OpenChallenges
- Sage Monorepo
- Schematic
- Synapse
- Other
- type: checkboxes
attributes:
Expand Down
8 changes: 6 additions & 2 deletions .github/ISSUE_TEMPLATE/4-story.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,17 @@ title: '[Story] <title>'
labels: []
body:
- type: dropdown
id: projects
id: products
attributes:
label: What projects is this story for?
label: What product(s) is this story for?
multiple: true
options:
- Agora
- OpenChallenges
- Sage Monorepo
- Schematic
- Synapse
- Other
- type: textarea
attributes:
label: 'As a user, I want'
Expand Down
1 change: 0 additions & 1 deletion .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"prConcurrentLimit": 5,
"ignorePaths": [
"apps/api",
"apps/challenge-db-cli",
"libs/api-client-angular-deprecated"
],
"baseBranches": ["main"],
Expand Down
Loading
Loading