Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: read from momento api key #382

Merged
merged 5 commits into from
Jul 9, 2024
Merged

ci: read from momento api key #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f98e96e
refactor: storage tests should use a single test store and base
malandis Jul 9, 2024
234da3b
fix: existing store test
malandis Jul 9, 2024
7fee081
refactor: rename `BaseTestClass` to `BaseCacheTestClass` for clarity
malandis Jul 9, 2024
763e74e
ci: read credentials from `MOMENTO_API_KEY`
malandis Jul 9, 2024
ae1076e
Merge branch 'main' into ci/read-from-momento-api-key
malandis Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ jobs:
build:
runs-on: ubuntu-latest
env:
TEST_AUTH_TOKEN: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }}
MOMENTO_API_KEY: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }}
TEST_CACHE_NAME: java-integration-test-ci-${{ github.sha }}

steps:
- name: Checkout project
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ jobs:
runs-on: ubuntu-latest

env:
TEST_AUTH_TOKEN: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }}
TEST_CACHE_NAME: dummy
MOMENTO_API_KEY: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }}

permissions:
actions: read
Expand Down
2 changes: 1 addition & 1 deletion momento-sdk/src/intTest/java/momento/sdk/BaseCacheTestClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class BaseCacheTestClass {

@BeforeAll
static void beforeAll() {
credentialProvider = CredentialProvider.fromEnvVar("TEST_AUTH_TOKEN");
credentialProvider = CredentialProvider.fromEnvVar("MOMENTO_API_KEY");
cacheClient =
CacheClient.builder(credentialProvider, Configurations.Laptop.latest(), DEFAULT_TTL_SECONDS)
.build();
Expand Down
2 changes: 1 addition & 1 deletion momento-sdk/src/intTest/java/momento/sdk/BaseStorageTestClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class BaseStorageTestClass {

@BeforeAll
static void beforeAll() {
credentialProvider = CredentialProvider.fromEnvVar("TEST_AUTH_TOKEN");
credentialProvider = CredentialProvider.fromEnvVar("MOMENTO_API_KEY");
storageClient =
new PreviewStorageClientBuilder()
.withCredentialProvider(credentialProvider)
Expand Down
Loading