-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overlapping file lock exception #5489
Conversation
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Tested locally with this:
Breaks on the released version and works fine with this PR build 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could get this into a patch release that would be amazing 🙏🏻
modules/nextflow/src/main/groovy/nextflow/conda/CondaCache.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Made a change to use normalised absolute path + using more compact sip hash algorithm. How this solution is going to be validated? |
I could try to add an integration tests that installs miniconda and runs the pipeline which reproduces the error. Do you think it is enough? |
I was more thinking running a real pipeline to replicate the problem. Maybe @ewels knows more |
I was trying to validate earlier this morning already, but couldn't get the original error to trigger any more 🙈 I'll clean up my env and try again shortly. Maybe @maxulysse or @pinin4fjords could also have a go? |
I can definitively replicate the original error |
@maxulysse nice. Are you able to make a local build with this branch and try it? |
It's a success 🚀 |
Great! |
I was too slow, but I just checked on GitPod and was able to replicate the error and confirm that it's now fixed on |
Signed-off-by: jorgee <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Fix conda packages with same name and content but different path.
Include a hash of the path in the environment prefix directory.