[Bug] Metal Burst causes game to crash if intended target faints

[seanrmon]

What are the changes the user will see?

Metal burst will no longer cause game to crash if there are no valid targets.

Why am I making these changes?

I believe this was caused by [Refactor] Refactor move phase and add documentation (#3974), which is currently in use on the beta branch.

What are the changes from a developer perspective?

In resolveCounterAttackTarget(), if attacker is null then this.targets[0] does not get set and this.scene.getField()[this.targets[0]].hp will lead to a memory access violation.

Screenshots/Videos

PokeRogue.Mozilla.Firefox.2024-10-04.17-27-35.mp4

How to test the changes?

sessionData_metalburstcrash.txt

Use Water Spout and Metal Burst. See video.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[DayKev]

The solution that fixed this last time was

pokerogue/src/phases/move-phase.ts

Lines 378 to 382 in f562a76

	const attacker = this.pokemon.scene.getPokemonById(this.pokemon.turnData.attacksReceived[0].sourceId);
	if (attacker?.isActive(true)) {
	this.targets[0] = attacker.getBattlerIndex();
	}

being changed to this.targets[0] = this.pokemon.turnData.attacksReceived[0].sourceBattlerIndex; it seems (or maybe that change was made independently, I'm not 100% sure; the git history for this section got clobbered :regiDespair:).
Putting that code back fixes the problem (Metal Burst redirects instead of crashing), whereas yours stops the crash but causes Metal Burst to fail instead of redirecting.

[DayKev]

I'll re-add the code that got reverted and add some tests to prevent this happening again.

[DayKev]

Btw sorry to "steal" the PR like this, but since it's a crash issue I wanted to get it fixed w/tests ASAP.