-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add metadata lock when using the plan cache #51897
Conversation
Signed-off-by: wjhuang2016 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51897 +/- ##
=================================================
- Coverage 72.1372% 56.4929% -15.6444%
=================================================
Files 1467 1599 +132
Lines 426900 621672 +194772
=================================================
+ Hits 307954 351201 +43247
- Misses 99709 246773 +147064
- Partials 19237 23698 +4461
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: wjhuang2016 <[email protected]>
/retest |
Signed-off-by: wjhuang2016 <[email protected]>
/test check-dev |
@wuhuizuo: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/parser/model/model.go
Outdated
@@ -542,6 +542,8 @@ type TableInfo struct { | |||
|
|||
TTLInfo *TTLInfo `json:"ttl_info"` | |||
|
|||
TableVersion uint64 `json:"table_version"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ModificationCount
is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment here. In particular, explain how "ModificationCount" differs from "Version".
Signed-off-by: wjhuang2016 <[email protected]>
/retest |
1 similar comment
/retest |
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
/retest |
Signed-off-by: wjhuang2016 <[email protected]>
Signed-off-by: wjhuang2016 <[email protected]>
/retest |
2 similar comments
/retest |
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51407
Problem Summary:
When executing the prepared statement from the plan cache, tidb doesn't add the metadata lock, which may cause data-index inconsistency.
What changed and how does it work?
PREPARE
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.