Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Exchange of the canonical function #336

Closed
wants to merge 1 commit into from
Closed

refactor: Exchange of the canonical function #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions workflow/resources/datavzrd/variant-calls-template.datavzrd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,14 +304,12 @@ views:
canonical:
optional: true
display-mode: detail
plot:
heatmap:
scale: "ordinal"
domain: ["", "True"]
range:
- white
- black
custom-content: ?empty_content
spell:
url: v1.1.3/logic/boolean
with:
true_value: "true"
false_value: "false"
custom-content: ?empty_content
mane_plus_clinical:
optional: true
display-mode: detail
Expand Down Expand Up @@ -481,14 +479,12 @@ views:
canonical:
optional: true
display-mode: detail
plot:
heatmap:
scale: "ordinal"
domain: ["", "True"]
range:
- white
- black
custom-content: ?empty_content
spell:
url: v1.1.3/logic/boolean
with:
true_values: "true"
false_values: "false"
custom-content: ?empty_content
Comment on lines +482 to +487
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix inconsistent configuration keys between coding and non-coding sections

The boolean spell configuration uses different key names in the coding and non-coding sections:

  • Coding section: true_value, false_value
  • Non-coding section: true_values, false_values (plural)

This inconsistency could cause the non-coding section to fail. Both sections should use the same key names.

Apply this fix to maintain consistency:

  spell:
    url: v1.1.3/logic/boolean
    with:
-     true_values: "true"
-     false_values: "false"
+     true_value: "true"
+     false_value: "false"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
spell:
url: v1.1.3/logic/boolean
with:
true_values: "true"
false_values: "false"
custom-content: ?empty_content
spell:
url: v1.1.3/logic/boolean
with:
true_value: "true"
false_value: "false"
custom-content: ?empty_content

mane_plus_clinical:
optional: true
display-mode: detail
Expand Down
Loading