Replaces General Mob Spawns in Rooms with Spawners [DONE] #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
2 times, most recently
from
05a3dbf
to
4fbbce5
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
4 times, most recently
from
475513e
to
ec7c5f1
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
6 times, most recently
from
f5126a4
to
1b26ee6
Compare
InsightfulParasite
changed the title
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
3 times, most recently
from
b8f59e3
to
b930d9a
Compare
InsightfulParasite
assigned Kitsunemitsu and InsightfulParasite and unassigned InsightfulParasite
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
2 times, most recently
from
0f9cd34
to
42d8cea
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
from
42d8cea
to
b92ec4e
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
2 times, most recently
from
703ba55
to
257c9e2
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
from
257c9e2
to
5951bda
Compare
|
|
||
| return INITIALIZE_HINT_QDEL | ||
|
|
||
| /obj/effect/spawner/mobspawner/proc/ReturnPlacementTurfs() |
There was a problem hiding this comment.
This proc notably does not include checks for dense objects.
There was a problem hiding this comment.
continue
var/bad_turf = FALSE
for(var/obj/O in turf_in_view)
if(O.density)
bad_turf = TRUE
break
if(!bad_turf)
. += turf_in_view
Does this work as a solution or should i keep looking into it?
My only fear with this check is if it encounters a turf that has 30+ objects on it.
5951bda
to
0566f5c
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
from
0566f5c
to
1937b1e
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
2 times, most recently
from
d35e0dd
to
1d2f90d
Compare
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
2 times, most recently
from
ec09a6c
to
6072beb
Compare
Mod Spawners are less haredcoded and can be edited in the code more easily. Mobs that have map edited names will remain untouched. fix: scatter/steel_noon_fly being the same path as scatter/steel_noon tweak: gcorp.dmm tweak: sweeper_ca.dmm tweak: apartment_lna.dmm tweak: apartment_lsa.dmm tweak: scorp.dmm replaced mobs with spawners. tweak: scorp_warehouse.dmm replaced mobs with spawners tweak: gcorp_armory replaced mobs with spawners tweak: supermarket.dmm replaced mobs with spawners. tweak: gmanager_house.dmm added a wallvent and plate for livelyness. tweak: love_train.dmm i opened the map and a bunch of charge weapons were removed due to not existing anymore. tweak: robot_city.dmm i noticed 2 turrets were shooting constantly at some robots outside of their sight lines so i changed their stat to off. Did not touch turrets at vault door. tweak: shrimp_vault.dmm replaced most with spawners but certain deliberately placed shrimp were left to their own devices. tweak: lcorp_office.dmm rearranged some things for better perspective such as doors and posters. tweak: moved office_kcorp .dmm from medium east to west tweak: dry_cleaners.dmm tweak: freezer_sw contained a varient of amber_bug/morsel that no longer exists. tweak: pet_store puts all the pets in pet boxes because that might make them not process their AI as much. tweak: gcorp_swa.dmm tweak: rat_ssa.dmm replaced the two rats with a elite spawner so its two random elite rats every intialization. Update scorp_vault.dmm replace scatter with mobspawners
InsightfulParasite
force-pushed
the
cityfixer-room-edits
branch
from
6072beb
to
e81b959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Mod Spawners are less hardcoded and can be edited in the code more easily. Mobs that have map edited names will remain untouched.
Fixes dry_cleaners.dmm having no air as mentioned in #2079
Why It's Good For The Game
Fixes some things.
Changelog
🆑
fix: scatter/steel_noon_fly being the same path as scatter/steel_noon
tweak: gcorp.dmm
tweak: sweeper_ca.dmm
tweak: apartment_lna.dmm
tweak: apartment_lsa.dmm
tweak: scorp.dmm replaced mobs with spawners.
tweak: scorp_warehouse.dmm replaced mobs with spawners
tweak: gcorp_armory replaced mobs with spawners
tweak: supermarket.dmm replaced mobs with spawners.
tweak: gmanager_house.dmm added a wallvent and plate for livelyness.
tweak: love_train.dmm i opened the map and a bunch of charge weapons were removed due to not existing anymore.
tweak: robot_city.dmm i noticed 2 turrets were shooting constantly at some robots outside of their sight lines so i changed their stat to off. Did not touch turrets at vault door.
tweak: shrimp_vault.dmm replaced most with spawners but certain deliberately placed shrimp were left to their own devices.
tweak: eye_temple.dmm moved the shock trap to a more obvious and avoidable spot.
tweak: lcorp_office.dmm rearranged some things for better perspective such as doors and posters.
tweak: moved office_kcorp .dmm from medium east to west
tweak: dry_cleaners.dmm
tweak: freezer_sw contained a varient of amber_bug/morsel that no longer exists.
tweak: pet_store puts all the pets in pet boxes because that might make them not process their AI as much.
tweak: gcorp_swa.dmm
tweak: rat_ssa.dmm replaced the two rats with a elite spawner so its two random elite rats every intialization.
/:cl: