feat: add dispatch subscription for generic_subscirption #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
===========================================
+ Coverage 25.14% 36.88% +11.73%
===========================================
Files 58 28 -30
Lines 3297 2047 -1250
Branches 1075 1062 -13
===========================================
- Hits 829 755 -74
+ Misses 1734 562 -1172
+ Partials 734 730 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: yamasaki <[email protected]>
ymski
force-pushed
the
enable_dispatch_subscription_callback
branch
from
1946bbb
to
639b7d5
Compare
6 tasks
5 tasks
xygyo77
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
The following three PRs, including this PR, were identified.
tier4/rclcpp#7
#228
#220
I confirmed that the graph drawing was the same before and after the application of the above 3 PRs on Pilot.Auto's Psim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable the
dispatch_subscription_callbacktrace point for supportingRclcpp::GenericSubscription.Related links
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.