feat(GenericSubscription): Add dispatch subscription callback to generic subscription #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
6 tasks
isp-uetsuki
requested changes
Oct 25, 2023
Co-authored-by: isp-uetsuki <[email protected]>
6 tasks
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
|
Remove redundant include in a51c1ab. Could you review it again? @isp-uetsuki |
5 tasks
xygyo77
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
The following three PRs, including this PR, were identified.
#7
tier4/caret_trace#228
tier4/caret_trace#220
I confirmed that the graph drawing was the same before and after the application of the above 3 PRs on Pilot.Auto's Psim.
7 tasks
iwatake2222
pushed a commit
that referenced
this pull request
Nov 30, 2023
…ric subscription (#7) * added initialization tracepoint to generic_subscription Signed-off-by: yamasaki <[email protected]> * added callback_register Signed-off-by: yamasaki <[email protected]> * added callback_start/end Signed-off-by: yamasaki <[email protected]> * added subscription-side trace point Signed-off-by: ymski <[email protected]> * add rclcpp_publish to generic_publisher Signed-off-by: ymski <[email protected]> * removed unused dispatch_subscription_callback trace point Signed-off-by: ymski <[email protected]> * Update rclcpp/src/rclcpp/generic_subscription.cpp Co-authored-by: isp-uetsuki <[email protected]> * fix messege addr Signed-off-by: ymski <[email protected]> * remove redundant includes Signed-off-by: ymski <[email protected]> --------- Signed-off-by: yamasaki <[email protected]> Signed-off-by: ymski <[email protected]> Co-authored-by: isp-uetsuki <[email protected]>
iwatake2222
added a commit
that referenced
this pull request
Nov 30, 2023
…ric subscription (#7) (#8) * added initialization tracepoint to generic_subscription * added callback_register * added callback_start/end * added subscription-side trace point * add rclcpp_publish to generic_publisher * removed unused dispatch_subscription_callback trace point * Update rclcpp/src/rclcpp/generic_subscription.cpp * fix messege addr * remove redundant includes --------- Signed-off-by: yamasaki <[email protected]> Signed-off-by: ymski <[email protected]> Co-authored-by: ymski <[email protected]> Co-authored-by: isp-uetsuki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow applications using GenericSubscription/GenericPublisher to be analyzed by CARET.
Add trace points to each class that are required for analysis in CARET.
( see https://tier4.github.io/caret_doc/latest/design/trace_points/runtime_trace_points/. )
Added tracepoints
Related links
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.