CPDNPQ-1188 Create a task to update status fields in the NPQ #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
2 times, most recently
from
7be595f
to
97a28c3
Compare
|
Created review app at https://npq-registration-review-app-819.london.cloudapps.digital |
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
8 times, most recently
from
2f61c54
to
0a54b62
Compare
javier-npq
changed the title
javier-npq
commented
Jun 30, 2023
app/lib/services/ecf/ecf_application_synchronization_service.rb
Outdated
Show resolved
Hide resolved
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
2 times, most recently
from
a77e3e6
to
3616686
Compare
slawosz
reviewed
Jul 6, 2023
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
from
4dba6bb
to
1a5a482
Compare
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
from
9e0945a
to
6a1901e
Compare
BroiSatse
reviewed
Jul 7, 2023
app/lib/services/ecf/ecf_application_synchronization_service.rb
Outdated
Show resolved
Hide resolved
BroiSatse
reviewed
Jul 7, 2023
|
There's one potential issue with scalability here. If we enable cron on our docker, all the deployed instances will run cron in the background causing multiple execution of the same job. Also, running things in the background is a bit against of cloud architecture. In ideal world, we should have a single dedicated container responsible for running cron - this would also resolve issues with invisible cron logs. |
slawosz
reviewed
Jul 7, 2023
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
3 times, most recently
from
f9fec2c
to
9ab3815
Compare
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
from
9ab3815
to
52f20db
Compare
javier-npq
commented
Jul 7, 2023
slawosz
reviewed
Jul 10, 2023
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
from
e0a2c29
to
09ca92c
Compare
javier-npq
force-pushed
the
CPDNPQ-1188-background-job-to-update-status-fields
branch
from
8b560ac
to
451b3e6
Compare
slawosz
approved these changes
Jul 10, 2023
|
Approved. It would be worth it to verify manually few days after deployment, if the applications are properly being updated. |
javier-npq
deleted the
CPDNPQ-1188-background-job-to-update-status-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-1188
ECF counterpart
PR: DFE-Digital/early-careers-framework#3561
Changes proposed in this pull request