-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPDNPQ-1188 Create a task to update status fields in the NPQ #819
CPDNPQ-1188 Create a task to update status fields in the NPQ #819
Conversation
7be595f
to
97a28c3
Compare
Created review app at https://npq-registration-review-app-819.london.cloudapps.digital |
2f61c54
to
0a54b62
Compare
app/lib/services/ecf/ecf_application_synchronization_service.rb
Outdated
Show resolved
Hide resolved
a77e3e6
to
3616686
Compare
4dba6bb
to
1a5a482
Compare
9e0945a
to
6a1901e
Compare
app/lib/services/ecf/ecf_application_synchronization_service.rb
Outdated
Show resolved
Hide resolved
There's one potential issue with scalability here. If we enable cron on our docker, all the deployed instances will run cron in the background causing multiple execution of the same job. Also, running things in the background is a bit against of cloud architecture. In ideal world, we should have a single dedicated container responsible for running cron - this would also resolve issues with invisible cron logs. |
f9fec2c
to
9ab3815
Compare
9ab3815
to
52f20db
Compare
e0a2c29
to
09ca92c
Compare
8b560ac
to
451b3e6
Compare
Approved. It would be worth it to verify manually few days after deployment, if the applications are properly being updated. |
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-1188
ECF counterpart
PR: DFE-Digital/early-careers-framework#3561
Changes proposed in this pull request