Preliminary support for Ubuntu 24 and Ubuntu 24 ARM #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into update_python
…into update_python
itsarune
requested review from
a team,
raymond212,
Muxite,
Lmh-java,
mkhlb,
Mr-Anyone,
AmyKawa,
wmostrenko and
annieisawesome2
and removed request for
a team
|
Could someone with an ARM computer run the following command and let me know if it works: |
|
I gave it a try - it didn't work: ERROR: Skipping '//software/embedded:host_platform': no such package 'software/embedded': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package. |
|
It worked on my machine. |
|
I have tried a few entries in thunderscope and it worked! One thing to note when running autoref is that a warning message is spammed: This seems to be a google protobuf python warning |
|
Apart from that, LGTM! |
Mr-Anyone
approved these changes
Oct 20, 2024
|
Yeah, I saw this error too. We aren't using |
4 tasks
|
perfectly fine with it |
|
deal with it once it will be a issues |
4 tasks
Lmh-java
pushed a commit
to Lmh-java/Software
that referenced
this pull request
Oct 25, 2024
…3316) * Update to python 3.10.0 and bazel 5.4.0 * No need to import `typing` for collections as of python 3.9 * Update black formatter to 24.4.2 * Run fix_formatting.sh * Remove PyOpenGL-accelerate dependency * Install latest pip in setup_software.sh * Install latest pip in setup_software.sh * Testing * Testing * Remove testing * Bump pyqtgraph to 0.13.3 * Update setup_software.sh * Try fixing precommit * Try fixing precommit * Try fixing precommit * Replace black/autoflake with ruff * Remove black binary * Remove git attribute * Remove unused check_formatting_ci.sh * Run fix_formatting.sh * Add simulated/field test fixtures to conftest.py * Address UBC-Thunderbots#3251 * Python code cleanup and fix Thunderscope * Enable pydocstyle rules in ruff * Add compile pip requirements to pre-commit * Formatting and fix pre-commit * Fix pre-commit * Fix pre-commit * Fix pre-commit and fsm_diagram_generator.py * Update docstrings * Formatting * Fix type errors * Nuke jetson_nano/display :( * Switch to pyqtdarktheme * Bump pytqtgraph to 0.13.7 * If build fails, download autoref from Google Drive mirror * Fix setup_software.sh * If build fails, download autoref from releases in github fork * Remove Qt deps from ER Force Simulator and improve code quality * Remove Qt from bazel and setup_software.sh * Misc code quality changes * Rename formatting_scripts to scripts * Fix docstring * FIx docstring * [pre-commit.ci lite] apply automatic fixes * Add ASCII diagram to robotmesh.cpp * Fix pyqtdarktheme dep missing * Misc changes * Nits * Use python dataclasses, remove unused stuff, nits * [pre-commit.ci lite] apply automatic fixes * Use dataclass * Update setup_software for Ubuntu 24 ARM Start migrating to python3.12 * fixup installation issues * Working on pybind11 compilation * downgrade pybind11 slightly * thunderscope is running, but slowly + autoref problems * play around with newer protobuf version * Fix python protobuf slowness * update ssl protos * resolve some build issues * Seems to compile correctly on x86 Ubuntu 2020 * fix a whole bunch of issues and leave a bunch more * Wip add support for new Tigers Autoref * Remove auto_continue from old gamecontroller proto message * Wip update autoref wrapper with new autoref * [pre-commit.ci lite] apply automatic fixes * Fixup last little niggly issues with game controller and autoref migration * fixing up formatting * migrate to gcc 10 and upgrade boost * improve jetson toolchain * work on nano build * fix jetson nano * fix ensurepip for ubuntu 24 * update linux gcc extlibs paths * not yet compiling, adding arm64 support * update cross compile toolchain names * wip * wip * [pre-commit.ci lite] apply automatic fixes * update setup software for pyqt6 * install nvm * works on William (not William's) computer * update g3log and some docs * update tbots_protobuf_test * [pre-commit.ci lite] apply automatic fixes * update github 24 arm machine * hopefully fix platform io in CI * wip toolchain resolution issue * fixup github builds mayhaps * cleanup PR and fixup tests * address PR comments * cleanup documentation * [pre-commit.ci lite] apply automatic fixes * fixup clang format for ARM builds --------- Co-authored-by: williamckha <[email protected]> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: arun <[email protected]> Co-authored-by: wmostrenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Summary of changes:
python stepping to python 3.12 (required to install pyqt6 on ARM devices via the system package, pip install was broken)
updated SSL game controller to latest (for ARM binaries)
updated Tigers Autoref to latest (new game controller also updates several protobuf definitions)
What works:
ARM bazel build works
X86 full_system/thunderscope/jetson compilation works
What doesn't work:Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue