Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-airlift][tutorial] Assets forward tutorial #25193

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Oct 10, 2024

Summary & Motivation

Assets forward version of the tutorial. Also changes some of the wording

How I Tested These Changes

Existing tests

Changelog

NOCHANGELOG

Copy link
Contributor Author

dpeng817 commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dpeng817 and the rest of your teammates on Graphite Graphite

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless necessary for tests, I don't think we should have rebuild_customer_list_assets as separate functions. Would rather have those inlined.

Copy link
Contributor Author

Yea, I don't think it's necessary anymore since we only have one top-level definitions object now. Before it would induce multiple to inline them.

@dpeng817 dpeng817 force-pushed the dpeng817/assets_tutorial branch 2 times, most recently from 0a38773 to 9dabb6f Compare October 14, 2024 17:13
@dpeng817 dpeng817 deleted the dpeng817/assets_tutorial branch October 14, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants