-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-airlift] Support dag-level overrides in builder #25243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2024
dpeng817
force-pushed
the
dpeng817/introduce_dag_handle
branch
from
October 14, 2024 00:43
0c21efc
to
01e7151
Compare
dpeng817
force-pushed
the
dpeng817/support_dag_override_assets
branch
from
October 14, 2024 00:43
1b8156c
to
b6a9bf9
Compare
schrockn
reviewed
Oct 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/airflow_defs_data.py
Outdated
Show resolved
Hide resolved
schrockn
reviewed
Oct 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/sensor/sensor_builder.py
Show resolved
Hide resolved
schrockn
reviewed
Oct 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/serialization/compute.py
Outdated
Show resolved
Hide resolved
schrockn
reviewed
Oct 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/utils.py
Outdated
Show resolved
Hide resolved
schrockn
reviewed
Oct 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/serialization/compute.py
Outdated
Show resolved
Hide resolved
schrockn
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a round of naming consistency pass here around "mapped task" and "mapped dag"
dpeng817
force-pushed
the
dpeng817/introduce_dag_handle
branch
from
October 14, 2024 15:49
01e7151
to
f2fd07a
Compare
dpeng817
force-pushed
the
dpeng817/support_dag_override_assets
branch
2 times, most recently
from
October 14, 2024 15:52
1d0dbbc
to
0f92514
Compare
schrockn
reviewed
Oct 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/serialization/compute.py
Outdated
Show resolved
Hide resolved
schrockn
reviewed
Oct 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/serialization/compute.py
Outdated
Show resolved
Hide resolved
schrockn
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please heed final naming suggestion!
dpeng817
force-pushed
the
dpeng817/support_dag_override_assets
branch
from
October 14, 2024 19:59
0f92514
to
2cd574f
Compare
This was referenced Oct 14, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Support dag-level override behavior in the airflow builder.
This iteration explicitly duplicates some implementation pathways across dag / task enrichment.
How I Tested These Changes
A new test for e2e behavior with sensor.
Changelog
NOCHANGELOG