Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-airlift] Support dag-level overrides in builder #25243

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[dagster-airlift] Support dag-level overrides in builder #25243

merged 1 commit into from
Oct 14, 2024

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Oct 11, 2024 •
edited
Loading

Summary & Motivation

Support dag-level override behavior in the airflow builder.

This iteration explicitly duplicates some implementation pathways across dag / task enrichment.

How I Tested These Changes

A new test for e2e behavior with sensor.

Changelog

NOCHANGELOG

This was referenced Oct 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@dpeng817 Graphite App
Copy link
Contributor Author

dpeng817 commented Oct 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dpeng817 and the rest of your teammates on Graphite Graphite

@dpeng817 dpeng817 mentioned this pull request Oct 11, 2024
Merged
@dpeng817 dpeng817 marked this pull request as ready for review October 11, 2024 23:09
@dpeng817 dpeng817 force-pushed the dpeng817/introduce_dag_handle branch from 0c21efc to 01e7151 Compare October 14, 2024 00:43
@dpeng817 dpeng817 force-pushed the dpeng817/support_dag_override_assets branch from 1b8156c to b6a9bf9 Compare October 14, 2024 00:43
@dpeng817 dpeng817 mentioned this pull request Oct 14, 2024
Merged
schrockn
schrockn requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a round of naming consistency pass here around "mapped task" and "mapped dag"

@dpeng817 dpeng817 force-pushed the dpeng817/introduce_dag_handle branch from 01e7151 to f2fd07a Compare October 14, 2024 15:49
@dpeng817 dpeng817 force-pushed the dpeng817/support_dag_override_assets branch 2 times, most recently from 1d0dbbc to 0f92514 Compare October 14, 2024 15:52
schrockn
schrockn approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please heed final naming suggestion!

Base automatically changed from dpeng817/introduce_dag_handle to master October 14, 2024 19:57
@dpeng817 dpeng817 force-pushed the dpeng817/support_dag_override_assets branch from 0f92514 to 2cd574f Compare October 14, 2024 19:59
@dpeng817 dpeng817 merged commit c54bb0e into master Oct 14, 2024
1 check was pending
@dpeng817 dpeng817 deleted the dpeng817/support_dag_override_assets branch October 14, 2024 20:00
This was referenced Oct 14, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrockn schrockn schrockn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpeng817 @schrockn