Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-airlift] [tutorial] Improve code snippet parsing in tutorial #25268

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Oct 14, 2024

Summary & Motivation

Previously you had to hardcode the code snippet files in two places, now you just add them as a comment in the place where they are used.

How I Tested These Changes

Tested on the actual tutorial, which resulted in a few changes.

Changelog

NOCHANGELOG

Copy link
Contributor Author

dpeng817 commented Oct 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dpeng817 and the rest of your teammates on Graphite Graphite

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to porting this to proper docs site!

@dpeng817 dpeng817 force-pushed the dpeng817/dag_level_override_custom_callback branch from ffa77e7 to b75f2d6 Compare October 15, 2024 20:01
Base automatically changed from dpeng817/dag_level_override_custom_callback to master October 15, 2024 20:01
@dpeng817 dpeng817 merged commit b8ea604 into master Oct 15, 2024
1 check was pending
@dpeng817 dpeng817 deleted the dpeng817/fix_snippet_parsing branch October 15, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants