-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-airlift] [tutorial] Improve code snippet parsing in tutorial #25268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
dpeng817
changed the title
[dagster-airlift] [tutorial] fix readme parsing
[dagster-airlift] [tutorial] Improve code snippet parsing in tutorial
Oct 14, 2024
This was referenced Oct 14, 2024
This was referenced Oct 14, 2024
schrockn
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to porting this to proper docs site!
dpeng817
force-pushed
the
dpeng817/dag_level_override_custom_callback
branch
from
October 15, 2024 17:41
6a93b8f
to
ffa77e7
Compare
dpeng817
force-pushed
the
dpeng817/fix_snippet_parsing
branch
2 times, most recently
from
October 15, 2024 18:09
efe6b1b
to
303263c
Compare
This was referenced Oct 15, 2024
dpeng817
force-pushed
the
dpeng817/dag_level_override_custom_callback
branch
from
October 15, 2024 20:01
ffa77e7
to
b75f2d6
Compare
dpeng817
force-pushed
the
dpeng817/fix_snippet_parsing
branch
from
October 15, 2024 20:01
303263c
to
36840a0
Compare
Base automatically changed from
dpeng817/dag_level_override_custom_callback
to
master
October 15, 2024 20:01
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Previously you had to hardcode the code snippet files in two places, now you just add them as a comment in the place where they are used.
How I Tested These Changes
Tested on the actual tutorial, which resulted in a few changes.
Changelog
NOCHANGELOG