-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-airlift] Remove airflow variable parsing #25289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
dpeng817
force-pushed
the
dpeng817/cli_requirements
branch
from
October 15, 2024 21:34
6614ba7
to
4cd5b8d
Compare
dpeng817
force-pushed
the
dpeng817/remove_af_vars
branch
from
October 15, 2024 21:34
4fe3240
to
8f83d99
Compare
This was referenced Oct 15, 2024
schrockn
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dpeng817
force-pushed
the
dpeng817/cli_requirements
branch
from
October 16, 2024 18:03
4cd5b8d
to
f221567
Compare
dpeng817
force-pushed
the
dpeng817/remove_af_vars
branch
from
October 16, 2024 18:04
8f83d99
to
dde0981
Compare
dpeng817
force-pushed
the
dpeng817/cli_requirements
branch
from
October 16, 2024 20:03
f221567
to
59b8d9a
Compare
dpeng817
force-pushed
the
dpeng817/remove_af_vars
branch
from
October 16, 2024 20:03
dde0981
to
e98dabb
Compare
dpeng817
force-pushed
the
dpeng817/remove_af_vars
branch
from
October 16, 2024 20:06
e98dabb
to
5edf65d
Compare
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The sensor no longer relies on retrieving airflow "proxied" state from variables, so we can delete all this garbage 🎉
How I Tested These Changes
Existing tests, had to delete a few
Changelog
NOCHANGELOG