-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-dlift] rename DbtCloudInstance to DbtCloudClient #25481
Open
dpeng817
wants to merge
1
commit into
dpeng817/dpeng817/get_tests
Choose a base branch
from
dpeng817/rename_to_client
base: dpeng817/dpeng817/get_tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2024
This was referenced Oct 24, 2024
dpeng817
force-pushed
the
dpeng817/dpeng817/get_tests
branch
from
October 24, 2024 17:13
692b0e4
to
afd5aaa
Compare
dpeng817
force-pushed
the
dpeng817/rename_to_client
branch
from
October 24, 2024 17:13
2d0bd37
to
ebb7540
Compare
This was referenced Oct 24, 2024
dpeng817
force-pushed
the
dpeng817/dpeng817/get_tests
branch
from
October 24, 2024 17:42
afd5aaa
to
1de15bb
Compare
This was referenced Oct 24, 2024
dpeng817
force-pushed
the
dpeng817/rename_to_client
branch
from
October 24, 2024 17:42
ebb7540
to
5bb6d99
Compare
This was referenced Oct 24, 2024
dpeng817
force-pushed
the
dpeng817/dpeng817/get_tests
branch
from
October 25, 2024 01:03
1de15bb
to
1e0e90f
Compare
dpeng817
force-pushed
the
dpeng817/rename_to_client
branch
from
October 25, 2024 01:03
5bb6d99
to
0e88de6
Compare
This was referenced Oct 25, 2024
dpeng817
force-pushed
the
dpeng817/dpeng817/get_tests
branch
from
October 25, 2024 16:20
1e0e90f
to
01f58cc
Compare
dpeng817
force-pushed
the
dpeng817/rename_to_client
branch
from
October 25, 2024 16:21
0e88de6
to
4a5ac65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
In preparation for adding more classes - this fits better the function of this class.
How I Tested These Changes
Existing