-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-dlift] get_models #25446
Open
dpeng817
wants to merge
1
commit into
dpeng817/scaffold_testing
Choose a base branch
from
dpeng817/dpeng817/dlift_get_models
base: dpeng817/scaffold_testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[dagster-dlift] get_models #25446
dpeng817
wants to merge
1
commit into
dpeng817/scaffold_testing
from
dpeng817/dpeng817/dlift_get_models
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2024
This was referenced Oct 23, 2024
dpeng817
force-pushed
the
dpeng817/scaffold_testing
branch
from
October 24, 2024 04:20
d89c48a
to
a92b83d
Compare
dpeng817
force-pushed
the
dpeng817/dpeng817/dlift_get_models
branch
from
October 24, 2024 04:20
90dfdd3
to
51051a0
Compare
This was referenced Oct 24, 2024
dpeng817
force-pushed
the
dpeng817/scaffold_testing
branch
from
October 24, 2024 17:13
a92b83d
to
2bcdfbd
Compare
dpeng817
force-pushed
the
dpeng817/dpeng817/dlift_get_models
branch
from
October 24, 2024 17:13
51051a0
to
aa3d165
Compare
dpeng817
force-pushed
the
dpeng817/scaffold_testing
branch
from
October 24, 2024 17:41
2bcdfbd
to
784c97b
Compare
dpeng817
force-pushed
the
dpeng817/dpeng817/dlift_get_models
branch
from
October 24, 2024 17:42
aa3d165
to
8b3c96d
Compare
This was referenced Oct 24, 2024
This was referenced Oct 24, 2024
dpeng817
force-pushed
the
dpeng817/dpeng817/dlift_get_models
branch
from
October 25, 2024 01:02
8b3c96d
to
f3c3619
Compare
This was referenced Oct 25, 2024
dpeng817
force-pushed
the
dpeng817/scaffold_testing
branch
from
October 25, 2024 16:20
784c97b
to
567b3a7
Compare
dpeng817
force-pushed
the
dpeng817/dpeng817/dlift_get_models
branch
from
October 25, 2024 16:20
f3c3619
to
09ba21e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add method to retrieve models from the rest API.
How I Tested These Changes
Added both a live test and a unit test.